[Bug 239918] Review Request: php-pear-Net-Traceroute - Execute traceroute

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Traceroute - Execute traceroute


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239918





------- Additional Comments From tibbs at math.uh.edu  2007-05-15 18:53 EST -------
I suggest changing the %description to:
  OS independent wrapper class for executing traceroute calls.
to fix a misspelling and add a period.

I think this package should have a runtime depdency on traceroute; otherwise I'm
not sure what the point is.

* source files match upstream:
   a3a25932b9e81ebbec7f12035859bbd336d0b334d0c8bca5b15386a672c45463  
   Net_Traceroute-0.21.1.tgz
* package meets naming and versioning guidelines.
? specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
? final provides and requires are sane:
   php-pear(Net_Traceroute) = 0.21.1
   php-pear-Net-Traceroute = 0.21.1-1.fc7
  =
   /bin/sh
   /usr/bin/pear
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.