[Bug 239954] Review Request: ruby-ncurses - A module for ruby applications for using ncurses interfaces

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-ncurses - A module for ruby applications for using ncurses interfaces


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239954


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-18 14:28 EST -------
Well,

* For ruby-ncurses itself:
  - For commands, please choose to use either command name or
    macros for consistency.
    For example, current spec file uses both "chmod" and "%{__chmod}".
    And where "make" is written directly, "%{__rm}" is used
    with macro...

    If you want to use macros as possible (for commands), please
    change "make" to "%{__make}", "chmod" to "%{__chmod}",
    and INSTALL="install -p" to INSTALL="%{__install} -p".

    (Of course make %{__install} is wrong)

* For review
  - Well, the review request you chose seems easy, but I will trust
    you. Okay!!

------------------------------------------------------
   This package (ruby-ncurses) is APPROVED by me
-------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account". 

At a stage, you will submit a request which tells sponsor
members that  you need a sponsor. After you do so, please let me know
on this bug for confirmation. Then I will sponsor you.

Note: now Fedora 8 branch is created, the valid branches
on http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
is:
FC-5, FC-6, F7 and devel.

If you have some questions, please let me know.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.