[Bug 239901] Review Request: corkscrew - Tool for tunneling SSH through HTTP proxies.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: corkscrew - Tool for tunneling SSH through HTTP proxies.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239901





------- Additional Comments From debarshi.ray at gmail.com  2007-05-19 01:51 EST -------
(In reply to comment #1)
> The package builds fine; rpmlint says:
>   W: corkscrew summary-ended-with-dot Tool for tunneling SSH through HTTP proxies.
> Should be a trivial fix.

Fixed.

> Note that Source0: should be a URL, so that spectool, for example, can download
> the source.

Fixed.

> You must include the license text (COPYING) and really should include the rest
> of the included documentation (AUTHORS, ChangeLog, TODO) as %doc.

Done.

> Have you investigated how other distros package this program?  Debian includes a
> manpage and a couple of bugfix patches.

I have imported the online manual page, and some modifications to README and
corkscrew.c from Debian. I have also put in a patch for a typo in README.


> Finally, are you sponsored? A quick search didn't turn you up as the owner of
> any other packages.  If you don't have a sponsor, you'll need to add
> FE-NEEDSPONSOR to the "Bug 239901 blocks" field and point out reviews that
> you've done or other packages you've submitted so that the sponsors will have
> enough information to decide whether they would like to sponsor you.

No. I am not sponsored and have not yet reviewed any packages for Fedora since I
am very new to packaging myself. My involvement with Fedora till now has been in
the form of bug reports and a successful Summer of Code proposal
(http://fedoraproject.org/wiki/SummerOfCode/2007/DebarshiRay). Apart from Fedora
I contribute to GNU too.

NB: The modified SRPM and SPEC file are available at the links mentioned in the
initial review request.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.