[Bug 240642] Review Request: pidgin-libnotify - Libnotify Pidgin plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-libnotify - Libnotify Pidgin plugin
Alias: pidgin-libnotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240642


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review+




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-19 04:15 EST -------
(In reply to comment #3)
> (In reply to comment #1)
> > ? While you renamed the package name to pidgin-libnotify,
> >   why did you leave the name of the module as gaim-libnotify.so
> >   and gettext .mo files as gaim-libnotify??
> 
> The current patch merely fixes it to build against the new API of
> Pidgin/Libpurple. 
Okay.


> > * Why do you have this package provide "gaim-libnotify = 0.12-6",
> >   not gaim-libnotify = %{version}-%{release}" ?
> 
> Fixed in 0.12-7, and the files
Confirmed.

> (In reply to comment #2)
> > * And also check documentation. At least the contents
> >   of README should be fixed.
> 
> I didn't include the README 
Actually... Okay.

--------------------------------------------
This package (pidgin-libnotify) is APPROVED by me
--------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.