[Bug 240479] Review Request: vavoom - Enhanced Doom, Heretic, Hexen and Strife source port

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vavoom - Enhanced Doom, Heretic, Hexen and Strife source port


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240479





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-19 16:25 EST -------
(In reply to comment #1)
> A couple of questions:
> 
> * Location of scripts
>   - Do the 4 bash scripts have to be located under %_bindir?
>     It seems that these scripts are to be used to download
>     some game data and are to be called normally from GNOME
>     menu.
>     IMO these scripts should be located under %_libexecdir/%name,
>     for example. I don't want to have some base directory (such
>     as %_bindir) polluted by scripts for temporal use.
> 

They are not for temporal use, they invoke autodownloader only once, but after
that they are still needed to pass the necessary magick cmdline options to
vavoom to make it play doom, or heretic or hexen or strife.

And since some people like launching stuff from the cmdline instead of digging
through layers of menus, the should be in %{_bindir} so that people can type
doom-shareware on the cmdline, instead off having to remember to invoke "vavoom
-iwaddir ~/.vavoom/doom-shareware -doom"

Also these scripts do not add any overhead as they end with an exec.

> * URL
>   - Could you specify the URL of the "Source"s (especially 
>     of some png files) as possible?
doom-logo.png was taken from a doom-sharware package created by Wart, you would
have to ask him.

tux-b2f.png was created by my from the well known born to frag tux image.
through the use of gimp to downsize and make it transparent, see:
http://images.google.nl/images?q=tux+born+2+frag

>   - Also, could you provide the URL of the licenses of game
>     data written on autodlrc files (if I understand autodlrc
>     correctly)?

This are the licenses of the to be downloaded files.

The heretic and hexen texts can be founds in the zips downloaded (see autodlrc
files for their url's), and are a verbatim copy and paste except for some
whitespace changes.

The doom license text is a verbatim copy and paste of the debian copyright file:
http://packages.debian.org/changelogs/pool/non-free/d/doom-wad-shareware/doom-wad-shareware_1.9-1.1/doom-wad-shareware.copyright

The latest doom shareware zip no longer includes this text (vendor.doc) I assume
this is an oversight on ID's side.

I don't know where debian got this text from, presumably from an older shareware
version. The text is very similar to the heretic license text and thus seems
genuine to me, I trust Debian on this (no reason not to really).

>     Rather, can't these autodlrc files be created automatically
>     from license text and some other needed information?
> 

Thats possible, but I don't see the use of this, it will just generate a lot of
work to get this right.

(In reply to comment #2)
> Created an attachment (id=155047)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155047&action=view) [edit]
> mock build log of  vavoom-1.23-1 on FC-devel i386
> 
> And mockbuild failed on FC-devel i386.
> 

Ah, my bad, here is a fixed version:
Spec URL: http://people.atrpms.net/~hdegoede/vavoom.spec
SRPM URL: http://people.atrpms.net/~hdegoede/vavoom-1.23-2.fc8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.