[Bug 240808] Review Request: xorg-x11-drv-vermilion - Intel Vermilion driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-vermilion - Intel Vermilion driver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240808





------- Additional Comments From ajackson at redhat.com  2007-05-22 16:18 EST -------
(In reply to comment #3)

> 2. Non blocker. rpmlint says:
> W: xorg-x11-drv-vermilion mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
> line 12)
> Fix if you get a chance.

Fixed.

> 3. Shouldn't this package "Require: hwdata" ? It puts a file under
> /usr/share/hwdata/videoaliases/ which hwdata owns. Or does this get pulled in
> from some dependency of xorg-x11-server-Xorg?

% rpm -q --whatrequires hwdata       
pciutils-2.2.3-4
usbutils-0.71-2.1
kudzu-1.2.64-2
isdn4k-utils-3.2-54.fc7
rhpxl-0.43-1.fc7
system-config-display-1.0.51-1.fc7

None of those are in the dep chain for Xorg, afaik.  None of the other drivers
are requiring on hwdata yet, but they're all languishing in mergereview so
that's not really an excuse.

Fixed.

> 4. Doesn't build on ppc32. I get:
>  gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/xorg -O2 -g -pipe -Wall
> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
> -m32 -MT vermilion.lo -MD -MP -MF .deps/vermilion.Tpo -c vermilion.c  -fPIC
> -DPIC -o .libs/vermilion.o
> vermilion.c: In function 'VERMILIONKernelOpen':
> vermilion.c:380: warning: ignoring return value of 'fgets', declared with
> attribute warn_unused_result
> vermilion.c:916:2: error: #error VERMILIONReadMemory and VERMILIONWriteMemory
> only work on little endian
> make[2]: *** [vermilion.lo] Error 1
> make[2]: Leaving directory `/builddir/build/BUILD/xf86-video-vermilion-1.0.0/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/builddir/build/BUILD/xf86-video-vermilion-1.0.0'
> make: *** [all] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.8790 (%build)
> 
> Does this hardware exist on ppc? Perhaps ppc/ppc64 should also be excluded?

I'm not even close to sure.  I think it's x86 only for now.

Changed to ExclusiveArch: %{ix86}, might add x86_64 if the need presents itself.
 I suspect this is in-chipset hardware so would never need to be added to
anything but intel chipsets.

Updated:
http://people.redhat.com/ajackson/vermilion/xorg-x11-drv-vermilion.spec
http://people.redhat.com/ajackson/vermilion/xorg-x11-drv-vermilion-1.0.0-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.