[Bug 226577] Merge Review: xorg-x11-drv-apm
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 25 05:02:55 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: xorg-x11-drv-apm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226577
------- Additional Comments From tibbs at math.uh.edu 2007-05-25 01:02 EST -------
OK, I pulled the latest source and built. This BS rpmlint complaint squeaked in:
W: xorg-x11-drv-apm mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3)
I usually just ignore these.
Blame Jesse for the bogus changelog, I guess. It's certainly not anything to
block on.
I recall from the vermillion review that you decided these drivers should grow a
dependency on hwdata.
At first I was going to complain about the COPYING file not getting into the
final package, but then I read the file:
This is a stub file. This package has not yet had its complete licensing
information compiled.
so I don't suppose there would be much point.
I'm kind of surprised xorg-x11-server-sdk doesn't have a dependency on
pkgconfig. It looks like it should, since it included a .pc file. That would
mean that you don't need to have the separate build-time dependency in all of
these drivers.
So really this is fine except for /usr/share/hwdata/videoaliases being unowned.
* source files match upstream:
09d7e6cf30b94f141f8ebe2560b301a058f645e74108edc28c908e750865dcec
xf86-video-apm-1.1.1.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has only ignoreable errors.
* final provides and requires are sane:
apm_drv.so()(64bit)
xorg-x11-drv-apm = 1.1.1-4.fc7
=
xorg-x11-server-Xorg >= 1.0.99.901
* %check is not present; not possible to automatically test, and hardware to
test this is hard to come by in any case.
* no shared libraries are added to the regular linker search paths.
X places a file in /usr/share/hwdata/videoaliases but doesn't own it or depend
on anything that does.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la droppings.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list