[Bug 237336] Review Request: perl-Crypt-OpenSSL-X509 -- Perl OpenSSL bindings for X509 support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  perl-Crypt-OpenSSL-X509 -- Perl OpenSSL bindings for X509 support


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237336


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-05-26 17:18 EST -------
Not much to say here; everything looks good.  The only oddify is this:

Checking if your kit is complete...
Warning: the following files are missing in your kit:
        inc
        inc/Module
        inc/Module/Install
Please inform the author.

Except that those are actually there, as directories.  I don't think directories
are supposed to be listed separately in the manifest but I'm not really certain.
 Perhaps it's worth passing that on to upstream.

* source files match upstream:
   a10433ff68b70687bac6832d5814db730147d3dc0cbf3e61c08a0711851c879e  
   Crypt-OpenSSL-X509-0.4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   X509.so()(64bit)
   perl(Crypt::OpenSSL::X509) = 0.4
   perl-Crypt-OpenSSL-X509 = 0.4-3.fc7
  =
   libcrypto.so.6()(64bit)
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(base)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=10,  0 wallclock secs ( 0.07 cusr +  0.03 csys =  0.10 CPU)
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.