[Bug 239158] Review Request: perl-Net-Write - A portable interface to open and send raw data to network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Write - A portable interface to open and send raw data to network
Alias: perl-Net-Write

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239158





------- Additional Comments From tibbs at math.uh.edu  2007-05-26 17:50 EST -------
This package is under the Artistic license only and not both it and the GPL as
you indicate.

You need to add build dependencies on perl(Test), perl(Test::Pod) and 
perl(Test::Pod::Coverage) so that the tests will run.

I'd suggest packaging the included examples as documentation.  Some folks have
also been packaging the tests as documentation, but in this case I don't see how
those tests could possibly be useful as docs.

Review:
* source files match upstream:
   b31718768fbe43c78183fd2e45f83dee87b77f60075130e00ed87df96f9bec0b  
   Net-Write-1.00.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
X license field doesn't match the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X some BuildRequires are missing.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Net::Write) = 1.00
   perl(Net::Write::Layer)
   perl(Net::Write::Layer2)
   perl(Net::Write::Layer3)
   perl(Net::Write::Layer4)
   perl-Net-Write = 1.00-1.fc7
  =
   perl(Carp)
   perl(Class::Gomor::Array)
   perl(Exporter)
   perl(IO::Socket)
   perl(Net::Pcap)
   perl(Net::Write::Layer)
   perl(Socket)
   perl(Socket6)
   perl(constant)
   perl(strict)
   perl(warnings)
X %check is present but some tests are skipped due to missing dependencies.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.