[Bug 240633] Review Request: perl-CPANPLUS-Dist-Build - Module::Build extension for CPANPLUS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS-Dist-Build - Module::Build extension for CPANPLUS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240633


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-05-28 00:43 EST -------
I note the following bit from the test run:

t/02_CPANPLUS-Dist-Build..............print() on unopened filehandle STDERR at
/usr/lib/perl5/vendor_perl/5.8.8/CPANPLUS/Error.pm line 186.
print() on unopened filehandle STDERR at
/usr/lib/perl5/vendor_perl/5.8.8/CPANPLUS/Error.pm line 186.

This doesn't seem to bother anything, though.  Might be worth reporting upstream.

I know you like to package the test suites, but I'm really starting to wonder
whether it's actually a good idea to package a bunch of empty directories and
some tarballs in the documentation.  The extra bits are, however, small and
shouldn't hurt anything.

Review:
* source files match upstream:
   5cc954024402675a5ab50dae6ec8b1c3c92fd561e593b024a7fc1da726ea5d84  
   CPANPLUS-Dist-Build-0.05.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(CPANPLUS::Dist::Build) = 0.05
   perl(CPANPLUS::Dist::Build::Constants) = 0.01
   perl-CPANPLUS-Dist-Build = 0.05-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(CPANPLUS::Error)
   perl(CPANPLUS::Internals::Constants)
   perl(CPANPLUS::inc)
   perl(Config)
   perl(Cwd)
   perl(File::Spec)
   perl(FileHandle)
   perl(IPC::Cmd)
   perl(Locale::Maketext::Simple)
   perl(Module::Build) >= 0.28
   perl(Module::Load::Conditional)
   perl(Params::Check)
   perl(constant)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=43,  2 wallclock secs ( 1.76 cusr +  1.12 csys =  2.88 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.