[Bug 241758] Review Request: xar - The eXtensible ARchiver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xar - The eXtensible ARchiver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758


Jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |Jochen at herr-schmitt.de
               Flag|                            |fedora-review?




------- Additional Comments From Jochen at herr-schmitt.de  2007-05-30 16:44 EST -------
Good:
+ Rpmlint quite on source rpm.
+ Sources matches with upstream.
+ License ok.
+ Naming ok.
+ Local build works fine.
+ Rpmlint quite on xar main package.
+ Rpmlint quite on debuginfo package.
+ Package contains varbatin copy of the license text.
+ Local install and uninstall works fine
+ Local test of the application works fine.
+ Mock build works fine.


Bad:
- Bad Buildroot:
BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Duplicate BuildRequites:
Duplicate BuildRequires: zlib-devel (by libxml2-devel)
- xar-devel contains no docs.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.