[Bug 252128] Review Request: telepathy-haze - A multi-protocol Libpurple connection manager for Telepathy
bugzilla at redhat.com
bugzilla at redhat.com
Sat Nov 3 09:40:17 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: telepathy-haze - A multi-protocol Libpurple connection manager for Telepathy
Alias: telepathy-haze
https://bugzilla.redhat.com/show_bug.cgi?id=252128
------- Additional Comments From david at lovesunix.net 2007-11-03 05:40 EST -------
Take with grain of salt as I currently sporting a 104F fever.
== GOOD ==
+ Naming and version/release are appropriate.
+ License (GPLv2+) is Fedora-acceptable and matches the licenses of the source
files.
+ Spec file is written in American English, and is legible.
+ Builds fine in mock (F8, x86_64); all BuildRequires are listed
without duplicates or repeats via dependencies.
+ Final file/directory ownership is good, and does not conflict with system
packages. No duplicate files are listed.
+ Files listed properly with an appropriate %defattr(...) line.
+ A %clean section exists and includes only "rm -rf %{buildroot}" as required.
+ Macro usage is consistent.
+ The buildroot is properly cleaned at the beginning of %install (via "rm -rf
%{buildroot}").
+ All filenames are valid UTF-8.
+ All desired functionality is enabled
+ rpmlint is quiet
== BLOCKERS ==
http://www.ox.compsoc.net/~resiak/ is down, thus no way to confirm the tarballs
are really the issued ones from upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list