[Bug 354741] Review Request: clonekeen - "Commander Keen: Invasion of the Vorticons" clone

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clonekeen - "Commander Keen: Invasion of the Vorticons" clone


https://bugzilla.redhat.com/show_bug.cgi?id=354741


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-03 20:54 EST -------
How did you determine the version of the GPL in use?  I only see "GPL", no copy
of the license itself and no mention of GPL or version in any of the source
files except for what's in the scale2x directory.  I guess that makes the
original code "GPL+" and the linked product "GPLv2+", but if you have something
more definitive it would be nice to have it in the package.

Review:
* source files match upstream:
   4f46a8c22eda16ede27d6510090d2ee9cc9bd0ae7f43261289cae4b68e145842  
   CKBeta83_Src.zip
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
? summary is OK (assuming no trademark issues)
? description is OK (assuming no trademark issues)
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   clonekeen = 0.8.3-1.fc8
  =
   /bin/bash
   /bin/sh
   autodownloader
   hicolor-icon-theme
   libSDL-1.2.so.0()(64bit)
   libdynamite.so.0()(64bit)
   libpthread.so.0()(64bit)

* Game tested manually; seems to work fine.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* desktop file looks OK.

APPROVED, subject to the trademark thing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.