[Bug 248395] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat
bugzilla at redhat.com
bugzilla at redhat.com
Thu Nov 8 03:27:09 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat
https://bugzilla.redhat.com/show_bug.cgi?id=248395
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tibbs at math.uh.edu
------- Additional Comments From tibbs at math.uh.edu 2007-11-07 22:27 EST -------
It seems to me that this is more of an application that happens to have a Perl
library rather than a Perl library that happens to include an executable, so I
don't think it needs to be named like a Perl module. What matters is the
upstream name of the project, which seems to be SysUsage. It's perfectly OK to
downcase that, so "sysusage" is fine.
I note that there's a 2.6 out now; would you like to update?
It would be best to do any fixups like removing the hardcoded
/usr/local/sysusage bits in %prep, I think. %install shouldn't be modifying things.
There's no need for the explicit Requires: perl; rpm will figure it out. But it
doesn't hurt to have it there if you don't want to remove it.
Otherwise this package looks good to me.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list