[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741


s.marechal at jejik.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s.marechal at jejik.com




------- Additional Comments From s.marechal at jejik.com  2007-11-09 10:18 EST -------
Hello,

I am Sander Marechal, the upstream developer of gnome-hearts

> Once building, there are some rpmlint warnings:
> 
> gnome-hearts.x86_64: E: non-executable-script
> /usr/lib/python2.5/site-packages/gnome-hearts/players/pauline.py 0644
> (and many like it)
> 
> It seems to be a python habit to begin any file containing python code with the
> usual #! line even though the file is not intended to ever be run from the
> command line.  Most of the time I ignore such complaints, but please check to
> make sure those files aren't ever to be run directly; if they are, then they
> should be executable.

Things like this should probably be reported upstream instead of ignored. I
happened to chance upon this bug when searching Google for references to my
game. Else I wouldn't have known about this.

Anyway, it's been fixed in upstream subversion and will be part of the upcoming
2.1 release: http://svn.jejik.com/viewvc.cgi/gnome-hearts?view=rev&revision=163

> it would then fail your build with an error:
> /tmp/gnome-hearts.desktop: error: file contains multiple assignments of key "Name"
> 
> This is simply because the file has "Name=No name" and "Name=Hearts".

This has been fixed as well:
http://svn.jejik.com/viewvc.cgi/gnome-hearts?view=rev&revision=159

Kind regards,

-- 
Sander Marechal

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.