[Bug 245492] Review Request: ndesk-dbus-glib - glib mainloop integration for ndesk-dbus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ndesk-dbus-glib - glib mainloop integration for ndesk-dbus
Alias: ndesk-dbus-glib

https://bugzilla.redhat.com/show_bug.cgi?id=245492


peter at thecodergeek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From peter at thecodergeek.com  2007-11-12 02:24 EST -------
Mock build is good (testThe spec looks properly cleaned up as requested, except
for one tiny detail: Is there a reason for the %ifarch conditional in the update
spec's %install section? It looks to me that you're only using it to get the
proper lib or lib64 directory; in which case you can simply use %{_libdir}
instead of hardcoding /usr/lib or /usr/lib64. The reason I ask this is that
other 64-bit arches (secondary, AFAIK) exist that you'd probably want to add to
it if you choose to leave it as a conditional: ppc64, sparc64, alpha, et al.
Keeping it as a simple %{_libdir} macro would preclude the need for any such
conditional.

Other than that, ndesk-dbus-glib-0.4.1-1 is APPROVED. Please fix that up before
you import it. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.