[Bug 366121] Review Request: httrack - Website copier and offline browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: httrack - Website copier and offline browser


https://bugzilla.redhat.com/show_bug.cgi?id=366121





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-13 11:35 EST -------
Well, I have not checked your -2 srpm, however:

(In reply to comment #4)
>> * generic header file name and generic macro name in
>>   header file.
> Not yet fixed.
> 
> Many of the macros are used to differentiate between #ifdef _WIN32 and so on.
> Clearly we would not have _WIN32 defined in Fedora -- Fedora is GNU/Linux and
> not Windows. So can I just remove all those _WIN32 (and similar) specific
> portions from htsglobal.h ?

Well, the most problematic file is config.h
- At first, the name "config.h" is too generic.
- And this file contains many generic macros.

So A
- At first config.h must be removed.
- Then as htsglobal.h contains some generic macros
  defined in config.h like
--------------------------------------------------------
   124  #else
   125  
   126  #include "config.h"
   127  
   128  #ifndef FTIME
   129  #define HTS_DO_NOT_USE_FTIME
   130  #endif
   131  
   132  #ifndef SETUID
   133  #define HTS_DO_NOT_USE_UID
   134  #endif
   135  
-----------------------------------------------------
  Please rename FTIME and SETUID and define/undefine HTS_FTIME
  (for example) in some places, for example
  (by the way, are these lines really needed?)


> 
> > * Dependency for firefox or so
> 
> Fixed.
> 
> > * File entry
> >   - By the way, the file entries
> >
> > [...]
> >
> >     can be replaced by
> 
> I have used this style in all my specs, since I like to differentiate between
> directories and files. Maybe this sounds silly, but I hope you will allow it. :-)
> 
> Spec: http://rishi.fedorapeople.org/httrack.spec
> SRPM: http://rishi.fedorapeople.org/httrack-3.41.3-2.fc8.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.