[Bug 174883] Review Request: distcc -- A free distributed C/C++ compiler system

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 14 11:58:00 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: distcc -- A free distributed C/C++ compiler system


https://bugzilla.redhat.com/show_bug.cgi?id=174883





------- Additional Comments From ch.nolte at noltec.org  2007-11-14 06:58 EST -------
Enrico, it would be nice if you could elaborate a bit if someone does not have
an immediate understanding of what you are doing in your scripts or spec-files.
I guess you can see that there are "implicit" questions in Laurent's comments.

Laurent, the PATH has to be modified because if a user installs distcc it should
automagically be in the users path, so that it can be used with minimal effort.

As for the package: There are multiple rpmlint warnings. I would like you to fix
them. If you don't think that the warnings rpmlint gives are correct then please
tell us why you think so. I attach the warnings to this bug.

The script /etc/profile.d/distcc.sh is fine with me. However, for a better
understanding a one-line comment about what this script does would be good. One
other thing is that variable names like __c or __d are not self speaking.







-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list