[Bug 239164] Review Request: perl-Net-SinFP - Full operating system stack fingerprinting suite

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 15 01:39:08 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-SinFP - Full operating system stack fingerprinting suite
Alias: perl-Net-SinFP

https://bugzilla.redhat.com/show_bug.cgi?id=239164





------- Additional Comments From tibbs at math.uh.edu  2007-11-14 20:39 EST -------
Fails to build for me, due to a failure in %check:

t/01-use.............Can't locate Net/Packet/Consts.pm in @INC (@INC contains:...)

Looks like you need a build dependency on perl(Net::Packet).  Adding that gets
everything building; I'll assume it's there for the purposes of this review.

rpmlint says:
  perl-Net-SinFP.src:4: W: unversioned-explicit-provides SinFP
It would be best if you provided a version here:
  Provides: SinFP = %{version}-%{release}

Now I see a rather significant problem: the License.  The both README and
LICENSE in this package pretty clearly say "Artistic License" which would render
this package unacceptable for Fedora.  You have "GPL+ or Artistic" in your
License: tag; do you have some other source for this package being under the GPL?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list