[Bug 226274] Merge Review: perl-Parse-RecDescent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-Parse-RecDescent


https://bugzilla.redhat.com/show_bug.cgi?id=226274





------- Additional Comments From panemade at gmail.com  2007-11-14 23:59 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
122fa38d52a701897836370ae022f174  Parse-RecDescent-v1.95.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
 PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00.load....# Testing Parse::RecDescent 1.95.1
ok
t/basics.....Name "main::D" used only once: possible typo at t/basics.t line 15.
ok
t/pod........ok
All tests successful.
Files=3, Tests=21,  1 wallclock secs ( 0.52 cusr +  0.03 csys =  0.55 CPU)
+ Package perl-Parse-RecDescent-1.95.1-3.fc9 ->
  Provides: perl(Parse::RecDescent) perl(Parse::RecDescent::Action)
perl(Parse::RecDescent::ColCounter) perl(Parse::RecDescent::Directive)
perl(Parse::RecDescent::Error) perl(Parse::RecDescent::Expectation)
perl(Parse::RecDescent::InterpLit) perl(Parse::RecDescent::LineCounter)
perl(Parse::RecDescent::Literal) perl(Parse::RecDescent::OffsetCounter)
perl(Parse::RecDescent::Operator) perl(Parse::RecDescent::Production)
perl(Parse::RecDescent::Repetition) perl(Parse::RecDescent::Result)
perl(Parse::RecDescent::Rule) perl(Parse::RecDescent::Subrule)
perl(Parse::RecDescent::Token) perl(Parse::RecDescent::UncondReject)
 Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Carp)
perl(Parse::RecDescent) perl(Text::Balanced) perl(strict) perl(vars) perl(version)
APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.