[Bug 351711] Review Request: perl-Inline-Files - Allows for multiple inline files in a single perl file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Inline-Files - Allows for multiple inline files in a single perl file


https://bugzilla.redhat.com/show_bug.cgi?id=351711


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-11-15 01:31 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
1beb4548be878a28cafb379945c402b8  Inline-Files-0.62.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00init.......ok
t/01basics.....ok
t/02write......ok
t/03nowrite....ok
t/04create.....ok
t/05seek.......ok
t/06backup.....ok
t/07hash.......ok
All tests successful.
Files=8, Tests=67,  3 wallclock secs ( 0.99 cusr +  0.09 csys =  1.08 CPU)
+ Package perl-Inline-Files-0.62-2.fc9 ->
 Provides: perl(Inline::Files) = 0.62 perl(Inline::Files::Data)
perl(Inline::Files::Virtual) = 0.53
 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Cwd)
perl(Filter::Util::Call) perl(Inline::Files::Virtual) perl(strict) perl(vars)
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.