[Bug 385041] Review Request: swfdec - Flash animation rendering library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swfdec - Flash animation rendering library


https://bugzilla.redhat.com/show_bug.cgi?id=385041


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-11-15 15:49 EST -------
Rpmlint says (ignorable):

swfdec.src: W: mixed-use-of-spaces-and-tabs (spaces: line 106, tab: line 1)
swfdec-gtk.i386: W: no-documentation
swfdec-gtk-devel.i386: W: no-documentation

swfdec-devel requires cairo-devel (and maybe more, as seen in 
swfdec-0.5.pc).

It would be nice to keep the timestamsp of installed files, it
should be achieved with
make DESTDIR=$RPM_BUILD_ROOT install INSTALL='install -p'

Maybe MAINTAINERS should be in %doc 

also 
%check

make check 

could be nice?

Though I get some failures:
FAILURES: 4
          ./system-capabilities-query-5.swf
          ./system-capabilities-query-6.swf
          ./system-capabilities-query-7.swf
          ./system-capabilities-query-8.swf
FAIL: trace
===================
1 of 1 tests failed
===================


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.