[Bug 377391] Package review: perl-MLDBM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: perl-MLDBM


https://bugzilla.redhat.com/show_bug.cgi?id=377391


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |2.01-5
         Resolution|                            |CURRENTRELEASE
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-15 19:43 EST -------
* source files match upstream:
   e83550629724c9b2e4ddd3fe777c8240d44f62e37338361a59ebec5f8e8e3893  
   MLDBM-2.01.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(MLDBM) = 2.01
   perl(MLDBM::Serializer)
   perl(MLDBM::Serializer::Data::Dumper)
   perl(MLDBM::Serializer::FreezeThaw)
   perl(MLDBM::Serializer::Storable)
   perl-MLDBM = 2.01-5.fc9.1
  =
   perl >= 0:5.004
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Data::Dumper)
   perl(FreezeThaw)
   perl(Storable)
   perl(Tie::Hash)
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=4, Tests=22,  0 wallclock secs ( 0.09 cusr +  0.05 csys =  0.14 CPU)
  (There is one warning, which looks to be a bug in the test suite)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

And since this is already in the repo in this state, I'll go ahead and close
this ticket.  If you need to make a branching request, just reply and set the
fedora-cvs flag without reopening.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.