[Bug 374791] Review Request: libnxml - simple C library for parsing, writing and creating XML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnxml - simple C library for parsing, writing and creating XML


https://bugzilla.redhat.com/show_bug.cgi?id=374791





------- Additional Comments From tibbs at math.uh.edu  2007-11-17 22:02 EST -------
A few comments:

Why ExcludeArch?  Do you know for a fact that this doesn't run on Alpha or PPC,
but still runs on, say, PPC64?  And even then, make sure you spell it "alpha",
not "aplha".

Please just use one changelog at the end.

I'm not sure that the second and third paragraphs of the description are really
appropriate.  It is of little use to Fedora to state that the library works on
Windows, and the the rest is more appropriate to the project home page.

Your configure file is generated by autoconf, so you should just use the
%configure macro to pass all of the appropriate options.

Do you really need build dependencies on automake and autoconf?  You don't call
them.

I find it simpler to just delete the .la files instead of using %exclude.

You shouldn't generally package static libraries.  If you absolutely need to,
you must put them in a separate -static package.  See
http://fedoraproject.org/wiki/Packaging/Guidelines (the Exclusion of Static
Libraries section).

The package fails to build:
error: Installed (but unpackaged) file(s) found:
   /usr/lib/libnxml.a
   /usr/lib/libnxml.la
   /usr/lib/libnxml.so
   /usr/lib/libnxml.so.0
   /usr/lib/libnxml.so.0.18.1
   /usr/lib/pkgconfig/nxml.pc

These files are installed to /usr/lib instead of %_libdir, which happens to be
/usr/lib64 on the package I'm building on.  I think calling the configure script
properly would fix this.

You should call parallel make if possible with %{__make} %{?_spm_mflags}.

rpmlint (on the source package, at least, since I can't build the binary one) says:

  libnxml.src:10: W: hardcoded-packager-tag hs1
Don't use Packager.

  libnxml.src:55: E: configure-without-libdir-spec
You should call your configure script with %configure.

  libnxml.src: W: more-than-one-%changelog-section
Mentioned above.

  libnxml.src: W: strange-permission libnxml.spec 0600
  libnxml.src: W: strange-permission libnxml-0.18.1.tar.gz 0600
Generally the files in an srpm are mode 644.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.