[Bug 383621] Review Request: gnofract4d - Gnofract 4D is a Gnome-based program to draw fractals

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnofract4d - Gnofract 4D is a Gnome-based program to draw fractals


https://bugzilla.redhat.com/show_bug.cgi?id=383621





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-19 07:51 EST -------
Well, for 3.6-3:

* desktop-file-install
-----------------------------------------------------------
desktop-file-install --vendor fedora --delete-original \
        --dir $RPM_BUILD_ROOT%{_datadir}/applications \
        $RPM_BUILD_ROOT%{_datadir}/%{name}/%{name}.desktop
-----------------------------------------------------------
  - However the build.log shows:
-----------------------------------------------------------
   765  creating
/var/tmp/gnofract4d-3.6-3.fc9-root-kojibuilder/usr/share/applications
   766  copying gnofract4d.desktop ->
/var/tmp/gnofract4d-3.6-3.fc9-root-kojibuilder/usr/share/applications
   767  creating /var/tmp/gnofract4d-3.6-3.fc9-root-kojibuilder/usr/share/mime
..................................
   775  + desktop-file-install --vendor fedora --delete-original --dir
/var/tmp/gnofract4d-3.6-3.fc9-root-kojibuilder/usr/share/applications
/var/tmp/gnofract4d-3.6-3.fc9-root-kojibuilder/usr/share/gnofract4d/gnofract4d.desktop
-----------------------------------------------------------
    So at this stage, gnofract4d.desktop is installed under
    $RPM_BUILD_ROOT%_datadir/applications, not under
    $RPM_BUILD_ROOT%_datadir/%name .

* URL
  - Source0 URL must be
    http://downloads.sourceforge.net/.... , not 
    http://download.sourceforge.net/...

* Directory ownership issue
  - Well I don't know why I missed this issue on previous check, however
------------------------------------------------------------
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/share/gnofract4d/maps/
gnofract4d-3.6-3.fc9
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/share/gnofract4d/
file /usr/share/gnofract4d is not owned by any package
------------------------------------------------------------
    The %files entry %{_datadir}/%{name}/* must be replaced by
    %{_datadir}/%{name}/ .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.