[Bug 389701] Review Request: osmo - Personal organizer

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 19 22:07:43 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: osmo - Personal organizer


https://bugzilla.redhat.com/show_bug.cgi?id=389701





------- Additional Comments From wolfy at nobugconsulting.ro  2007-11-19 17:07 EST -------
This time the package builds OK, but %{_datadir}/locale/ should not be included
under %files, because 
- locales are already included via -f %{name}.lang, so this triggers "files
listed twice" warnings  (for instance:  File listed twice:
usr/share/locale/cs/LC_MESSAGES/osmo.mo)
- it takes ownership of %{_datadir}/locale/ and its descendant directories

It would also be nice if you would preserve the timestamp of the files which are
not modified (mainly those listed under %doc). I did not test with osmo, but
usually passing INSTALL="install -p" to %make install is enough for that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list