[Bug 392271] Review Request: perl-Perl-MinimumVersion - Find a minimum required version of perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  perl-Perl-MinimumVersion -  Find a minimum required version of perl


https://bugzilla.redhat.com/show_bug.cgi?id=392271


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-11-20 15:40 EST -------
* source files match upstream:
   d832d97f092976e8456460db1afe02be31505582211e912e256d4c8784ecec5f  
   Perl-MinimumVersion-0.15.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Perl::MinimumVersion) = 0.15
   perl-Perl-MinimumVersion = 0.15-1.fc9
  =
   /usr/bin/perl
   perl >= 0:5.005
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(File::Find::Rule)
   perl(Getopt::Long)
   perl(List::Util)
   perl(PPI)
   perl(PPI::Util)
   perl(Params::Util)
   perl(Perl::MinimumVersion)
   perl(base)
   perl(constant)
   perl(strict)
   perl(vars)
   perl(version)

* %check is present and all tests pass:
   All tests successful.
   Files=4, Tests=63,  1 wallclock secs ( 0.49 cusr +  0.09 csys =  0.58 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.