[Bug 393041] Review Request: libzip - C library for reading, creating, and modifying zip archives

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzip - C library for reading, creating, and modifying zip archives


https://bugzilla.redhat.com/show_bug.cgi?id=393041


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-11-20 16:18 EST -------
The man pages that correspond with API description should better
be in -devel. In main package:
%{_mandir}/man1/*zip*
in -devel:
%{_mandir}/man3/*zip*

I think it is better to keep timestamps, this should be achieved with
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'

I think it is a bit unfortunate to have the header file
named simply zip.h. Maybe it could be in a libzip subdir? This maybe 
could be achieved by passing
--includedir=%{_includedir}/libzip

the license looks like a BSD one (3 clauses) to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.