[Bug 354441] Review Request: nautilus-share - Easy sharing folder via Samba (CIFS) protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nautilus-share - Easy sharing folder via Samba (CIFS) protocol


https://bugzilla.redhat.com/show_bug.cgi?id=354441


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-23 08:01 EST -------
For 0.7.2-8:

* rpmlint for src
  - Please change the permission of tarball in
    srpm to 0644.

* BuildRequires
  - Please try to delete more BuildRequires
    * dbus-devel is required by gnome-vfs2-devel
    * gtk2-devel is required by eel2-devel
    * gnome-vfs2-devel is required by eel2-devel

  - And "BuildRequires: perl-XML-Parser" should be
    changed to "BuildRequires: perl(XML::Parser)".

* License
  - This license is GPLv2+, not GPL+.

* Timestamps
  - Please try to add 'INSTALL="install -p"' to
    'make install', not 'make' in %build section.

* Static archive removal
  - Please check if this configure accepts --disable-static
    option and this disables static archive creation
    automatically.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.