[Bug 397211] Review Request: redet - Regular expression development and execution tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: redet - Regular expression development and execution tool


https://bugzilla.redhat.com/show_bug.cgi?id=397211


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-11-23 16:25 EST -------
I think that in the make install line, INSTALL="%{__install} -p"
is not useful, and that you should add 
BINDIR=%{_bindir}

Also it seems to me that in the sed that sets the /usr/share path
it would be better to use the rpm macro, like

join %{_datadir} Redet

Strangely, nothing is installed in %{_datadir}/Redet?

Also since you try hard to keep timestamps, I think it would be better
to keep them despite the sed.


Also I would personally suggest to harcode the version in 
Patch0, such that it means the version since the patch 
was added or last changed.

Are the files Sample* useful? And FeatureList-groovy-en_us?
Maybe as %doc?

I think that xdg-open should be used instead of dillo as default 
browser, and added as a dependency.

It would be nice to provide the manual. It is even 
called from the program, from %{_datadir}/Redet/Manual/Manual.html
This would certainly mean using the redet-full-8.23.tar.bz2
tarball.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.