[Bug 398431] Review Request: libnids - Implementation of an E-component of Network Intrusion Detection System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnids - Implementation of an E-component of Network Intrusion Detection System


https://bugzilla.redhat.com/show_bug.cgi?id=398431


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-11-26 04:07 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
811b31c7a1c4c96442807913b5eb1c95  libnids-1.22.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libnids-1.22-1.fc9 ->
  Provides: libnids.so.1.21
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libglib-2.0.so.0 libgthread-2.0.so.0 libnsl.so.1
libpcap.so.0.9 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1
+ Package libnids-devel-1.22-1.fc9 ->
  Requires: libnids = 1.22-1.fc9 libnids.so.1.21
+ Not a GUI App.

SHOULD: 
1) According to
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2
you need to change Source URL.

2) Good to have defattr usage as defattr(-,root,root,-)

You can do above at time of cvs import also.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.