[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-26 06:59 EST -------
(In reply to comment #39)
> (In reply to comment #38)
> > - License seems GPLv2+
> 
> I'm no license expert so I'll take your word for it. How can one tell?
  Now we are checking all source files in the tarball to find out
  the license.

> 
> > - Please add
> > --------------------------------------------
> >   DESTDIR="install -p"
> > --------------------------------------------
> >   to "make install" to keep timestamps on installed files.
> >   While there are some cases in which this method doesn't work,
> >   this method usually works for recent Makefiles.
> 
> Or did you mean something like 'INSTALL="install -p"'? 
  My bad.. Actually I meant INSTALL="install -p"...

  Now I will wait for your pre-review or another review request
  (as I wrote in comment 38).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.