[Bug 323441] Review Request: trousers - The open-source TCG software stack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trousers - The open-source TCG software stack


https://bugzilla.redhat.com/show_bug.cgi?id=323441


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-27 09:02 EST -------
Hi, Kent:

Some random comments for 0.3.1-1.
(I just glanced at your spec file. I have not tried
 to rebuild your srpm, and so have not tried to
 install the rebuilt rpms)

- Please consider to use %?dist tag.
  http://fedoraproject.org/wiki/Packaging/DistTag

- Source must be given with full URL.
  http://fedoraproject.org/wiki/Packaging/SourceURL
  Please check the section "Sourceforge.net"

- For sourceforge hosted project, I prefer to use
  http://foo.sourceforge.net/ for URL.

- "Requires: gtk+, openssl" is not needed.
  * rpmbuild checks dependencies for libraries when rebuild is
    done and then adds the dependencies to Requires automatically.

- "Requires(post/postun): ldconfig" is not needed.

- "--prefix=/usr --libdir=%_libdir" is not needed for %configure.
  (You can check what %configure actually does by
   $ rpm --eval %configure).

- Please remove unneeded
  [ "${RPM_BUILD_ROOT}" != "/" ] && [ -d ${RPM_BUILD_ROOT} ] &&

- You should not turn chkconfig service on by default.

- Please use "-p" option for "cp" or "install" commands to
  keep timestamps on installed files.

- Now we recommend %defattr(-,root,root,-)

- This package seems to need tss user/group. Please refer to
  http://fedoraproject.org/wiki/Packaging/UsersAndGroups

- If you want to package static archives (for this package,
  %_libdir/libtddl.a), create -static subpackage and
  move all static archives to -static subpackage.

- Check what package owns %{_includedir}/tss/ and
  %_includedir/trousers directories.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.