[Bug 400911] Review Request: pioneers - Turnbased board strategy game (colonize an island)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pioneers - Turnbased board strategy game (colonize an island)


https://bugzilla.redhat.com/show_bug.cgi?id=400911





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-11-27 10:51 EST -------
(In reply to comment #1)
> The only thing I don't like in the spec file is that you override
> pkgdatadir during make install, but not during configure. Obviously,
> this can break in not so funny ways.
> 

Oops, that shouldn't be there copy and paste error from another spec, will
remove with the next release.

> $ find /usr/share/applications/*pion* | xargs -n 1 desktop-file-validate
> /usr/share/applications/fedora-pioneers.desktop: warning: key "Encoding" in
> group "Desktop Entry" is deprecated
> /usr/share/applications/fedora-pioneers-editor.desktop: warning: key "Encoding"
> in group "Desktop Entry" is deprecated
> /usr/share/applications/fedora-pioneers-server.desktop: warning: key "Encoding"
> in group "Desktop Entry" is deprecated
> 

These are upstream provided, I can patch them if you want, but I would rather
wait for non-critical changes like this to trickle downstream through upstream.

> $ pioneers-editor 
> 
> ** (pioneers-editor:5509): WARNING **: Pixmap not found:
> /usr/share/pixmaps/pioneers-editor.png
> 
> $ pioneers-server-gtk 
> 
> ** (pioneers-server-gtk:5512): WARNING **: Pixmap not found:
> /usr/share/pixmaps/pioneers-server.png
> 
> $ pioneers
> 
> ** (pioneers:13601): WARNING **: Pixmap not found: /usr/share/pixmaps/pioneers.png
> 
> 
> It uses these pixmaps for the window title bar.
>

Oops,

I'll guess I'll stop moving them them, my bad.

> Help menu gives this error:
> 
> 15:17:16 Show the manual: There was an error launching the default action
> command associated with this location.
> 

Hmm, I'll investigae this.

Can you do a full review, or do you want a new fixed release first?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.