[Bug 402141] Review Request: tokyocabinet - A modern implementation of a DBM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tokyocabinet - A modern implementation of a DBM


https://bugzilla.redhat.com/show_bug.cgi?id=402141





------- Additional Comments From dakingun at gmail.com  2007-11-28 09:38 EST -------
(In reply to comment #2)
> For 1.0.6-1:
> 
> * location of header files
>   - I suggest to hide all header files under %_includedir/%name
>     (this also requires some fixes for installed header files and
>      .pc file).
>
May I ask why?
 
> * Libs in tokyocabinet.pc
> -----------------------------------------------------------
> Libs: -lz -lpthread -lm -lc
> -----------------------------------------------------------
>   - should all be unneeded
>      as linkage is already done and no header files in
>      tokyocabinet-devel requires header files in zlib-devel
>      or so.
>
I'm really inclined to let these alone (upstream must have had a reason for
putting them there). But leaving -lz there would necessitate adding a require
for zlib-devel, so I'll patch out Libs in the .pc for now.

> * .3 man files
>   - should be moved to -devel subpackage.
Moved. Thanks


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.