[Bug 241654] Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges


https://bugzilla.redhat.com/show_bug.cgi?id=241654





------- Additional Comments From pertusus at free.fr  2007-11-28 17:13 EST -------
The perl(CGI) requires seems to be only for -cgi, and autodetected.

Similarly the perl requires is autodetected.

Shouldn't the cgi subpackage depend on httpd?

GPL isn't a valid license anymore, it is GPL+, GPLv2, GPLv2+...

The source archive timestamp isn't kept:
-rw-rw-r-- 1 dumas dumas 21599 jui 27  2006 ipcalc-0.41.tar.gz
-rw-rw-r-- 1 dumas dumas 21599 mai 29  2007 ../SOURCES/ipcalc-0.41.tar.gz

You can use wget -N, spectool -g and the corresponding curl option.

There are issues with the package as I tested. First the images
are considered as scripts with the conf file Manuel proposed. I
propose the following:

Alias /ipcalculator/ /usr/share/ipcalculator/
<Directory /usr/share/ipcalculator/>
    DirectoryIndex ipcalculator.cgi
    Options ExecCGI
    AddHandler cgi-script cgi
    order deny,allow
    deny from all
    allow from 127.0.0.1
</Directory>

The images should be owned by the -cgi subpackage.

There is a missing image files, bg.gif.  ipcalc.gif should be 
renamed ipcal03.gif.

<a href="ipcalc.png">Screenshot</a> (ipcalc works also at the prompt)<br>
should be changed to
<a href="http://jodies.de/ipcalc.png">Screenshot</a> (ipcalc works also at the
prompt)<br>
Similar with
<a href="ipcalc-archive">Archive</a><br>
<a href="ipcalc-faq/win32.html">How to run this under windows</a><br>


Suggestion:
use %{version} in 
Source0:        http://jodies.de/ipcalc-archive/ipcalc-%{version}.tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.