[Bug 290421] Review Request: TnL-data - Datafiles for Thunder and Lightning

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TnL-data - Datafiles for Thunder and Lightning


https://bugzilla.redhat.com/show_bug.cgi?id=290421


packages at amiga-hardware.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From packages at amiga-hardware.com  2007-10-01 16:02 EST -------
* rpmlint:
W: no-documentation

OK as there is none/documentation in main TnL rpm

* Package named correctly: YES
* Patches named correctly: N/A
* Spec file named correctly: YES
* Licence(s) acceptable: YES
* Licence field matches: YES
* Licence file installed: NO (OK as not included upstream)
* Spec file in American English: YES
* Source matches upstream: YES
* Locales use %find_lang: N/A
* Contains %clean: YES
* %install contain rm -rf %{buildroot} or similar: YES
* Specfile legible: YES
* Compiles and builds ok: YES
* Calls ldconfig in %post/%postun for shlibs: N/A
* Owns directories it creates: YES
* Duplicate files: NO
* Permissions set correctly: YES
* Consistent macro use: YES
* Separate -doc needed (for large docs): NO (no large docs)
* %doc affects runtime: NO
* Headers and static libs in -devel: N/A
* .pc files in -devel: N/A
* .so in -devel: N/A
* -devel requires base: N/A
* Contains .la files: NO
* Owns files it didn't create: NO
* .desktop files included and installed correctly: N/A
* Filenames valid UTF8: YES


Looks good. Package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.