[Bug 290431] Review Request: TnL - Thunder & Lightning - A futuristic action flight simulator game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TnL - Thunder & Lightning - A futuristic action flight simulator game


https://bugzilla.redhat.com/show_bug.cgi?id=290431





------- Additional Comments From packages at amiga-hardware.com  2007-10-01 16:55 EST -------
* rpmlint: NO PROBLEMS
* Package named correctly: YES
* Patches named correctly: YES
* Spec file named correctly: YES
* Licence(s) acceptable: YES
* Licence field matches: YES
* Licence file installed: YES (OK as included upstream)
* Spec file in American English: YES
* Source matches upstream: YES
* Locales use %find_lang: N/A
* Contains %clean: YES
* %install contain rm -rf %{buildroot} or similar: YES
* Specfile legible: YES
* Compiles and builds ok: NO              [!! See below]
* Calls ldconfig in %post/%postun for shlibs: N/A
* Owns directories it creates: YES
* Duplicate files: NO
* Permissions set correctly: YES
* Consistent macro use: NO                [!! See below]
* Separate -doc needed (for large docs): NO (no large docs)
* %doc affects runtime: NO
* Headers and static libs in -devel: N/A
* .pc files in -devel: N/A
* .so in -devel: N/A
* -devel requires base: N/A
* Contains .la files:  NO
* Owns files it didn't create: NO
* .desktop files included and installed correctly: YES
* Filenames valid UTF8: YES


1. Macro use could improved by using %{name} on the source line and requires
line to be consistent with your use elsewhere.


2. Does not compile properly due to missing buildrequires. You seem to be
missing boost-devel


It's worth mentioning but it segfaults for me on startup if /dev/dsp is in use.
Otherwise it starts up correctly. 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.