[Bug 280541] Review Request: setools - SELinux policy analysis tools
bugzilla at redhat.com
bugzilla at redhat.com
Wed Oct 3 09:13:45 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: setools - SELinux policy analysis tools
https://bugzilla.redhat.com/show_bug.cgi?id=280541
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-10-03 05:13 EST -------
For 3.3.1-5:
* Dependency
- For -devel subpackage
-------------------------------------------------
Requires: setools = %{version}-%{release}
-------------------------------------------------
This means -devel subpackage requires -libs, -libs-tcl,
-gui, -console subpackages?
* Desktop files
- For example, /usr/share/applications/apol.desktop
contains:
-------------------------------------------------
Categories=Application;System;X-Red-Hat-Base;
-------------------------------------------------
Here the categories "Application" "X-Red-Hat-Base" are
deprecated and they should be removed.
* Duplicate file entry
You can check if duplicate file entry exists by checking
"warning: File listed twice" message in build.log.
- For -libs-python subpackage:
--------------------------------------------------
%{pkg_py_lib}/
%{pkg_py_arch}/
--------------------------------------------------
This is the same directory on i386, x86_64 so these file
entries are duplicate. The correct one is:
--------------------------------------------------
%{pkg_py_lib}/
%ifarch x86_64 ppc64
%{pkg_py_arch}/
%endif
--------------------------------------------------
- For -gui subpackage:
--------------------------------------------------
%{tcllibdir}/apol_tcl/
%{tcllibdir}/apol_tcl/pkgIndex.tcl
--------------------------------------------------
"%{tcllibdir}/apol_tcl/" entry contains
"%{tcllibdir}/apol_tcl/pkgIndex.tcl"
Then:
-------------------------------------------------------------
NOTE: Before being sponsored:
This package will be accepted with another few work.
But before I accept this package, someone (I am a candidate)
must sponsor you.
Once you are sponsored, you have the right to review other
submitters' review requests and approve the packages formally.
For this reason, the person who want to be sponsored (like you)
are required to "show that you have an understanding
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
(at the time you are not sponsored, you cannot do
a formal review)
When you have submitted a new review request or have pre-reviewed other
person's review request, please write the bug number on this bug report
so that I can check your comments or review request.
Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")
Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list