[Bug 257381] Review Request: python-sqlalchemy0.3 - Modular and flexible ORM library for python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-sqlalchemy0.3 - Modular and flexible ORM library for python


https://bugzilla.redhat.com/show_bug.cgi?id=257381





------- Additional Comments From tibbs at math.uh.edu  2007-10-03 14:58 EST -------
rpmlint spews a bunch of complaints because all of the .py* files are
executable.  Is there some reason they need to be?

There's a test suite in the package and it seems to be runnable:

%check
export PYTHONPATH=./test
python test/alltests.py

Any reason why it isn't called?

* source files match upstream:
   49b75b85e3691e6e6a38d6372d0b7153efa929cf5df31abf1b612574c1b062f6  
   SQLAlchemy-0.3.10.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X rpmlint has complaints
* final provides and requires are sane:
  python-sqlalchemy0.3-0.3.10-3.fc8.noarch.rpm
   python-sqlalchemy0.3 = 0.3.10-3.fc8
  =
   python(abi) = 2.5
   python-setuptools >= 0.6c3
* %check is not present; no test suite upstream.

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions are all executable?
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Extra Eggs Guideline checks:
* egg is built from source
* egg doesn't download any dependencies during the build
* EGG-INFO directory is included in package
* compat package; easy_install -m is called in %install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.