[Bug 287801] Review Request: Sirius - Othello game for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 3 20:57:28 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Sirius - Othello game for GNOME
Alias: sirius

https://bugzilla.redhat.com/show_bug.cgi?id=287801





------- Additional Comments From makghosh at gmail.com  2007-10-03 16:57 EST -------
(In reply to comment #20)

Issues resolved:

> For -9:
> 
> * Tarball itself

The original tarball sirius-0.8.0.tar.gz is restored (md5sum:
e01d079ca62aa3cc85f542bb5e9389a5). Also I have added a sirius-0.8.0-docs.patch
to patch the required changes.

> * Fedora specific compilation flags
>   - Fedora specific compilation flags are not honored.
>     You can check the fedora compilation flags by
>     `rpm --eval %opflags
> 
>     For this package, configure.in contains unneeded line
> ---------------------------------------------------------
> CFLAGS="-g -O3"
> ---------------------------------------------------------
>     This overrides CFLAGS value. To pass correct cflags for
>     this package, 
> ---------------------------------------------------------
> make %{?_smp_mflags} CFLAGS="%{optflags}"
> ---------------------------------------------------------
>     is needed (i.e. again add CFLAGS option).

Added the CFLAGS option again to make tag for that useless line in configure.in.

The updated links are:
Spec URL: http://makghosh.fedorapeople.org/SPECS/sirius.spec
SRPM URL: http://makghosh.fedorapeople.org/SRPMS/sirius-0.8.0-10.fc7.src.rpm

The Koji scratch build is also successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=181839

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list