[Bug 291661] Review Request: asylum - SDL port of the game Asylum, originally for the Archimedes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asylum - SDL port of the game Asylum, originally for the Archimedes


https://bugzilla.redhat.com/show_bug.cgi?id=291661





------- Additional Comments From packages at amiga-hardware.com  2007-10-03 17:45 EST -------
(In reply to comment #3)

> Move %doc to top of %files to aid readability

I prefer %doc near the bottom, for me thats more readable. It suits the logical
order that I write specs. Installed files, doc files, ghosted files. Unless
there's a requirement to change it, I'd rather leave as-is.


> Not a blocker but definitely a suggestion.
> Some path details are "hardcoded" into the Makefile and makefile patch.
> While the location of /usr/bin /usr/share/asylum and /var/games/asylum are not
> likely to change anytime soon it would be more visible to make these changes
> with sed in the specfile making use of the available macros.


Well as I need to patch the Makefile anyway, I don't see a great deal of
advantage, otherwise it would make sense. It just turns it from a 1 stage
process to a 2 stage process. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.