[Bug 226360] Merge Review: readahead

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: readahead


https://bugzilla.redhat.com/show_bug.cgi?id=226360


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-04 01:10 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM but NOT for RPM.
  readahead.i386: W: non-conffile-in-etc /etc/readahead.d/default.early
  readahead.i386: W: non-conffile-in-etc /etc/readahead.d/default.later
  readahead.i386: W: service-default-enabled /etc/rc.d/init.d/readahead_later
  readahead.i386: W: service-default-enabled /etc/rc.d/init.d/readahead_later
  readahead.i386: W: service-default-enabled /etc/rc.d/init.d/readahead_early
  readahead.i386: W: service-default-enabled /etc/rc.d/init.d/readahead_early
  These can be ignored for this package.
+ source files match upstream.
b1b087681c06b66a4e4c7e944336db  readahead-1.4.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ package  readahead-1.4.2-2.fc8 ->
  Provides: config(readahead) = 1:1.4.2-2.fc8
  Requires: /bin/bash /bin/gawk /bin/sh config(readahead) = 1:1.4.2-2.fc8
libaudit.so.0 libauparse.so.0 libblkid.so.1 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libext2fs.so.2
procps rtld(GNU_HASH)
+ Not a GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.