[Bug 319031] Review Request: nget - Command line NNTP file grabber

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nget - Command line NNTP file grabber


https://bugzilla.redhat.com/show_bug.cgi?id=319031





------- Additional Comments From tibbs at math.uh.edu  2007-10-05 16:09 EST -------
This is a clean package; I have only a couple of questions:

Why do you rename "Changelog" to "ChangeLog"?  Is there something wrong with the
name upstream chose for this file?

I see that you have a build dependency on cppunit so I figured you were trying
to run the test suite; what you really need to run it is build dependencies on
cppunit-devel and python, plus
  %check
  make test
but unfortunately, while the test suite runs properly, some tests fail because
subterfuge isn't there (and doesn't seem to be available in Fedora).  It seems
that it isn't as optional as the nget documentation seems to imply.

So I guess there's no point in trying to run the test suite at this time, and so
you should probably remove the cppunit build depdendency and add some commentary
about the impossibility of running the test suite without subterfuge.

* source files match upstream:
   6ec0339c8e0e3e31504f5171f479f154d3c0ba2108377a0105fe4a5f5082ea69  
   nget-0.27.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires include unnecessary cppunit dependency.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   nget = 0.27.1-6.fc8
  =
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libpcre.so.0()(64bit)
   libpcreposix.so.0()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libz.so.1()(64bit)
? %check is not present; test suite doesn't seem to run properly.  This should 
   be documented.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* statically links against uulib; properly BuildRequires: uulib-static

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.