[Bug 247406] Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1


https://bugzilla.redhat.com/show_bug.cgi?id=247406


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-06 13:16 EST -------
For 0.5.2-0.3:

* zero-length document
  - Please explain why you need zero-length documents
-------------------------------------------------------
E: zero-length /usr/share/doc/libcompizconfig-0.5.2/README
E: zero-length /usr/share/doc/libcompizconfig-0.5.2/ChangeLog
-------------------------------------------------------

* undefined non-weak symbols
-------------------------------------------------------
W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XStringToKeysym
W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XKeysymToString
-------------------------------------------------------
  - As this srpm provides -devel subpackage, these undefined non-weak
    symbols cannot be allowed because this causes linkage failure.

* Timestamp
  - To keep timestamps on xml and header files, I recommend
-------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-------------------------------------------------------
    This method usually works on recent Makefiles.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.