[Bug 319191] Review Request: glaxium - An OpenGL space shooter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glaxium - An OpenGL space shooter


https://bugzilla.redhat.com/show_bug.cgi?id=319191





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-10-06 16:42 EST -------
(In reply to comment #1)
> Needs work:
> * Please install at least a 48x48 icon (required by the spec, see
>
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons)

I've had this discussion before, not sure if it was with you though. The spec
says: "Minimally you should install a 48x48 icon in the hicolor theme." Notice
the *should*, the spec also describes in much more detail how a toolkit /
application should search for icons. There it says that if an icon of the proper
size isn't found all other possible sizes should be searched, and the icon
should then be software scaled to the desired size. So installing a 128x128 icon
will work fine, and scaling it to 48x48 is useless (more then that it would
loose details when a bigger icon is wanted), as any toolkit / app following the
spec will do the scaling itself if needed.

> * Desktop file: the Icon tag should either use the full path to the icon or the
> icon name without extension (wiki:Packaging/Guidelines#desktop)
> 

Fixed.

Here is a new version:
Spec URL: http://people.atrpms.net/~hdegoede/glaxium.spec
SRPM URL: http://people.atrpms.net/~hdegoede/glaxium-0.5-2.fc8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.