[Bug 322161] Review Request: egoboo - A top down graphical (3D) RPG in the spirit of Nethack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: egoboo - A top down graphical (3D) RPG in the spirit of Nethack


https://bugzilla.redhat.com/show_bug.cgi?id=322161





------- Additional Comments From dan at danny.cz  2007-10-07 14:14 EST -------
Review:

OK	source files match upstream (no diff between the upstream rar archive and
your tar.gz):
	    b145050af8577bfba703235ef4a5383fe59c8029  egoboo-2.4.3.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license (GPL).
OK	license is open source-compatible. License text not included upstream
sources, but is in the data package (or preciselly in the windows installation
package) and an older version of sources.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (development/i386).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates (there are none).
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	is a GUI app, desktop file is included.

this package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.