[Bug 293971] Review Request: gurlchecker - A Gnome link validity checker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gurlchecker - A Gnome link validity checker
Alias: gurlchecker

https://bugzilla.redhat.com/show_bug.cgi?id=293971





------- Additional Comments From makghosh at gmail.com  2007-10-08 19:47 EST -------
(In reply to comment #17)
> (In reply to comment #16)
> > Also i haven't put gurlchecker in bodhi as yet. It's better to do after the
> > issues are fixed...right?
> Yes.
> 
> 
> Well, for 0.10.1-2:
> 
> * Possibly missing BuildRequires
>   - I usually checks possibly missing BuildRequres by highlighting
>     "no" string on build.log. Then:
> ----------------------------------------------------------
>    246  checking whether to use CROCO library (CSS2 w3c validation)... requested
>    247  checking for CROCO... no
>    248  libcroco-0.6.pc not found
>    249  configure: WARNING: You requested libcroco support, but it doesn't seem
> to be installed.
>    250  checking whether to use TIDY library (HTML w3c validation)... requested
>    251  checking for tidyCreate in -ltidy... no
>    252  configure: WARNING: You requested libtidy support, but it doesn't seem
> to be installed.
>    253  checking whether to use CLAMAV library (virii scan)... requested
>    254  checking for cl_loaddbdir in -lclamav... no
>    255  configure: WARNING: You requested libclamav support, but it doesn't seem
> to be installed.
>    256  checking whether to use GNUTLS library (HTTPS check)... requested
> ----------------------------------------------------------
>     Perhaps libcroco-devel, libtidy-devel, clamav-devel will
>     enable these missing support.
> 
>   - Also please check if this is desired.
> -----------------------------------------------------------
>    293          Generate GTK doc        (gtkdoc)        : no
> -----------------------------------------------------------

Fixed. BuildRequires:  libcroco-devel, libtidy-devel, clamav-devel
And also Generate GTK doc (no) is okay i think. Because in the spec file i have
used:
----------------------------------------------
%configure --disable-gtk-doc
----------------------------------------------
This is due to if I just use "%configure", though gtk-doc is generated it
returns with RPM buildroot error saying something like "following files are
instaled but not contained in source package" listing all the gtk-doc html files

> * Redundant Requires
> -----------------------------------------------------------
> Requires:	gnet2, gnutls
> -----------------------------------------------------------
>   - Usually these types of Requires are not needed.
>     rpmbuild checks the dependencies for libraries and adds them
>     to Requires automatically.
>     For this package, you can see:
> -----------------------------------------------------------
> $ rpm -q --requires gurlchecker | grep '\(gnet\|gnutls\).*so*'
> libgnet-2.0.so.0  
> libgnutls.so.13  
> libgnutls.so.13(GNUTLS_1_3)  
> -----------------------------------------------------------
>     So the dependencies for libraries in gnet2, gnutls are 
>     added, which will pull gnet2 gnutls packages automatically.
>     For example:
> -----------------------------------------------------------
> $ rpm -q --whatprovides libgnet-2.0.so.0
> gnet2-2.0.7-10.fc8
> -----------------------------------------------------------

Fixed. Removed Requires: gnet2, gnutls

> * Desktop file
>   - must be installed (checked) by desktop-file-install
>     (BR: desktop-file-utils needed).

Fixed.

> * Perl module BuildRequires 
> * Timestamp

Fixed these too. They are repeatation of od errors...shouldn't have erred them.

The updated links are:
Spec URL: http://makghosh.fedorapeople.org/SPECS/gurlchecker.spec
SRPM URL: http://makghosh.fedorapeople.org/SRPMS/gurlchecker-0.10.1-3.fc7.src.rpm

The Koji build task is: http://koji.fedoraproject.org/koji/taskinfo?taskID=187553

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.