[Bug 317581] Review Request: ruby-rpm - Ruby bindings for RPM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-rpm - Ruby bindings for RPM


https://bugzilla.redhat.com/show_bug.cgi?id=317581


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-09 03:39 EST -------
Well, for 1.2.3-2:

* File dependency
-----------------------------------------------------
BuildRequires: /usr/include/popt.h
-----------------------------------------------------
  - Because of a certain reason, we don't recommend to
    use this type of (Build)Requires (please check the
    section "File Dependencies" of
    http://fedoraproject.org/wiki/Packaging/Guidelines
    I don't know well about RHEL, however for fedora
-----------------------------------------------------
%if 0%{?fedora} > 8
BuildRequires: popt-devel
%endif
-----------------------------------------------------
    is recommended.

* SourceURL
  - It seems that "20469" should be "26403"
  - However 
    http://rubyforge.org/frs/download.php/26403/ruby-rpm-1.2.3.tgz
    seems different from the tarball in your srpm?
  ! Well, for rubyforge.org, the number like "26403" 
    seems to change every time new version is released.

* Encoding
-----------------------------------------------------
Forgot to mention: the only warning I get from rpmlint is
   W: file-not-utf8 /usr/share/doc/ruby-rpm-1.2.3/doc/refm.rd.ja

Any idea what encoding that file is ? (I don't know any Japanese, so I won't
know if I recoded anything right)
-----------------------------------------------------
  - This file is encoded in EUC-JP (well, I am a Japanese)
    (Many Japanese documents in *nix are encoded in EUC-JP or
     ISO-2022-JP, and many Japanese documents in M$ are encoded
     in SHIFT-JIS).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.