[Bug 310641] Review Request: GREYCstoration - An image denoising and interpolation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GREYCstoration - An image denoising and interpolation tool


https://bugzilla.redhat.com/show_bug.cgi?id=310641





------- Additional Comments From packages at amiga-hardware.com  2007-10-10 18:14 EST -------
* rpmlint: W: no-documentation

No problem.

* Package named correctly: YES
* Patches named correctly: YES                
* Spec file named correctly: YES
* Licence(s) acceptable: YES
* Licence field matches: YES
* Licence file installed: YES (and included upstream)
* Spec file in American English: YES
* Source matches upstream: YES                 (!! but see below)
* Locales use %find_lang: N/A
* Contains %clean: YES
* %install contain rm -rf %{buildroot} or similar: YES
* Specfile legible: YES
* Compiles and builds ok: YES (mock/i386/x86_64 all releases)
* Calls ldconfig in %post/%postun for shlibs: N/A
* Owns directories it creates: YES
* Duplicate files: NO
* Permissions set correctly: YES
* Consistent macro use: YES
* Separate -doc needed (for large docs): N/A
* %doc affects runtime: N/A
* Headers and static libs in -devel: N/A
* .pc files in -devel: N/A
* .so in -devel: N/A
* -devel requires base: N/A
* Contains .la files: NO
* Owns files it didn't create: NO
* .desktop files included and installed correctly: YES
* Filenames valid UTF8: YES


Ok there's only one thing I think you should fix. Please use the source zip file
labelled as 2.5.2, it is identical to 2.5.2.1 which I believe is a phantom
version accidentally uploaded by upstream. It will also alleviate the ugliness
in the SPEC file in relation to the .1 suffix stuck on everything. Remember to
strip it from your patch filename too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.